Working as a reviewer

Things to watch out for

  • assume good faith and competence, question with curiosity
  • discuss and iterate on overall design before discussing details in the code
  • if you foresee the review will take multiple phases, announce this to the submitter upfront to set expectations about process
  • review code for style, prefix "nit:" for small style recommendations
  • review the commit message: motivation alongside what was changed
  • check and double-check the release note: user-facing changes must be mentioned, and backward-incompatible change must be highlighted

The human side of things


More detailed guidelines / background: